syz-cluster: use base-commit hint from patch series for triage #6557
Conversation
If the series author provided a base-commit, use it. If applying the series against the base-commit fails, fall back to the default bisection method.
| continue | ||
| } | ||
| if series.BaseCommitHint == "" { // Usually base-commit is in patch 0 or 1. Check them all to be safe. | ||
| regex := regexp.MustCompile(`(?m)^base-commit:\s*([0-9a-fA-F]{40})$`) |
There was a problem hiding this comment.
We shouldn't compile the regexp for each message. Ideally it should be done once outside of the function, see the majority of other regexp.MustCompile cases.
There was a problem hiding this comment.
I'd also move this extraction to pkg/email.
| if series.BaseCommitHint == "" { // Usually base-commit is in patch 0 or 1. Check them all to be safe. | ||
| regex := regexp.MustCompile(`(?m)^base-commit:\s*([0-9a-fA-F]{40})$`) | ||
| matches := regex.FindStringSubmatch(email.Body) | ||
| if len(matches) >= 2 { |
There was a problem hiding this comment.
You can just check for nil.
There was a problem hiding this comment.
I wanted to avoid an unnecessary crash if the author wrote the tag and forgot the hash. But I just realized it wouldn't match in that case! Will update.
| SubjectTags []string `json:"subject_tags"` | ||
| PublishedAt time.Time `json:"published_at"` | ||
| Patches []SeriesPatch `json:"patches"` | ||
| BaseCommitHint string `json:"base_commit"` |
There was a problem hiding this comment.
Nit: let's keep json name similar to the field name.
There was a problem hiding this comment.
Please rebase it on top of the current master.
|
|
||
| // First try to use hints from the series description. | ||
| if series.BaseCommitHint != "" { | ||
| for _, tree := range trees { |
There was a problem hiding this comment.
Note that we should be able to determine the tree from the commit:
- Given a commit, we can query the branches that have it.
- Branches are prefixed by tree names (that's the way syz-cluster pulls them).
You can use #6553 as reference here.
2 participants
If the series author provided a base-commit, use it. If applying the series against the base-commit fails, fall back to the default bisection method.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md